[MPlayer-cvslog] r32783 - trunk/libaf/af_lavcac3enc.c

[Reimar Döffinger]

On 11 Jan 2011, at 14:15, cehoyos <subversion at mplayerhq.hu> wrote:
> Author: cehoyos
> Date: Tue Jan 11 14:15:36 2011
> New Revision: 32783
> 
> Log:
> Change a forgotten instance of string 'ac3' to 'ac3_fixed'.
> 
> Modified:
>   trunk/libaf/af_lavcac3enc.c
> 
> Modified: trunk/libaf/af_lavcac3enc.c
> ==============================================================================
> --- trunk/libaf/af_lavcac3enc.c    Tue Jan 11 14:09:46 2011    (r32782)
> +++ trunk/libaf/af_lavcac3enc.c    Tue Jan 11 14:15:36 2011    (r32783)
> @@ -98,7 +98,7 @@ static int control(struct af_instance_s 
>             s->lavc_actx->bit_rate = bit_rate;
> 
>             if(avcodec_open(s->lavc_actx, s->lavc_acodec) < 0) {
> -                mp_msg(MSGT_AFILTER, MSGL_ERR, MSGTR_CouldntOpenCodec, "ac3", bit_rate);
> +                mp_msg(MSGT_AFILTER, MSGL_ERR, MSGTR_CouldntOpenCodec, "ac3_fixed", bit_rate);
>                 return AF_ERROR;
>             }
>         }

Wouldn't it be better (possibly even considering performance) to make the filter request float input?
Actually it should request whatever the ac3 encoder requires, like that it's still possible for it to work with slightly older FFmpeg versions, making regression testing easier.