[MPlayer-cvslog] r32780 - in trunk: libao2/ao_dxr2.c libvo/vo_dxr2.c

[Diego Biurrun]

On Tue, Jan 11, 2011 at 01:10:00AM +0100, ranma wrote:
> 
> Log:
> Fix compiler warnings in ao_dxr2.c and vo_dxr2.c

Which ones?  Please add the warnings to the log message.

> --- trunk/libao2/ao_dxr2.c	Tue Jan 11 01:07:52 2011	(r32779)
> +++ trunk/libao2/ao_dxr2.c	Tue Jan 11 01:09:59 2011	(r32780)
> @@ -175,9 +175,11 @@ static int get_space(void){
>  
> +/* write_dxr2 from libvo/dxr2.c */
> +extern int write_dxr2(const unsigned char *data, int len);
> +
>  static void dxr2_send_lpcm_packet(unsigned char* data,int len,int id,unsigned int timestamp,int freq_id)
>  {
> -  int write_dxr2(const unsigned char *data, int len);

What warning does this fix?

In any case this forward declaration should be replaced by a header.

> --- trunk/libvo/vo_dxr2.c	Tue Jan 11 01:07:52 2011	(r32779)
> +++ trunk/libvo/vo_dxr2.c	Tue Jan 11 01:09:59 2011	(r32780)
> @@ -166,6 +166,9 @@ static char *ucodesearchpath[] = {
>  
> +int write_dxr2(const unsigned char *data, int len);

same

> +void dxr2_send_sub_packet(unsigned char* data,int len,int id,unsigned int timestamp);

This is wrong, the function should be made static instead.

Diego