[MPlayer-cvslog] r32780 - in trunk: libao2/ao_dxr2.c libvo/vo_dxr2.c

[Diego Biurrun]

On Thu, Jan 13, 2011 at 06:35:13PM +0100, Tobias Diedrich wrote:
> Diego Biurrun wrote:
> > Tobias Diedrich wrote:
> > > Duplicate prototype (ao_dxr2), missing prototypes and unused
> > > variable (vo_dxr2) IIRC.
> > 
> > You should paste the warnings into the log message.
> 
> Log message is updated now.

Thanks.

> > > > In any case this forward declaration should be replaced by a header.
> > > 
> > > I wanted to keep the changes minimal, I'm not sure it's worth
> > > spending more time cleaning up this part of the code.
> > > After all it was broken for about 6 Months and no one noticed.
> > > I myself no longer have the hardware to test.
> > > At least now it compiles again and doesn't give compiler warnings.
> > 
> > I valiantly fought to move all extern and forward declarations into
> > proper header files and would hate to see the effort subverted.
> 
> Seems like you missed these. :)
> I just saw that there already is an vo_dxr2.h which you created, but
> it never had these in it and also wasn't included from vo_dxr2.c,
> only from ao_dxr2.c. ;)

Yes, thanks for fixing :)

Diego