[MPlayer-cvslog] r32834 - in trunk/libmpcodecs: vf_perspective.c vf_pp7.c vf_sab.c

[Michael Niedermayer]

On Mon, Jan 31, 2011 at 10:13:16AM +0100, Diego Biurrun wrote:
> On Sun, Jan 30, 2011 at 11:57:16PM +0100, michael wrote:
> > 
> > Log:
> > Replace memalign() by av_malloc() in libmpcodecs. as it is not available in all platforms
> > ported from ffmpeg
> 
> This is hard to understand due to lack of punctuation.  Did you intend
> to say

i intended to add a . at the end of the first line, feel free to make that
change
I can make the change as well if you prefer.

> 
>   Replace memalign() by av_malloc() in libmpcodecs.
>   memalign() is not available on all platforms that FFmpeg supports.
> 
> or
> 
>   Replace memalign() by av_malloc() in libmpcodecs.
>   memalign() is not available on all platforms.
>   Change ported from the libmpcodecs branch of FFmpeg.

both wrong

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20110131/c48d73e5/attachment.pgp>