[MPlayer-cvslog] r33655 - trunk/gui/win32/interface.c

[Reimar Döffinger]

On Sun, Jun 19, 2011 at 03:12:07PM +0200, Diego Biurrun wrote:
> On Sun, Jun 19, 2011 at 02:57:54PM +0200, Diego Biurrun wrote:
> > On Sun, Jun 19, 2011 at 02:36:12PM +0200, reimar wrote:
> > > 
> > > Log:
> > > Implement uiStop and remove outdated comment.
> > > 
> > > --- trunk/gui/win32/interface.c	Sun Jun 19 14:26:38 2011	(r33654)
> > > +++ trunk/gui/win32/interface.c	Sun Jun 19 14:36:12 2011	(r33655)
> > > @@ -431,6 +431,11 @@ void uiEnd( void )
> > >      guiGetEvent(guiCEvent, (void *) guiSetStop);
> > >  }
> > >  
> > > +void uiStop()
> > > +{
> > > +    guiGetEvent(guiCEvent, (void *) guiSetStop);
> > > +}
> > 
> > The cast is ugly :-/
> 
> Given this prototype
> 
>   int guiGetEvent(int type, void *arg)
> 
> the cast should not be necessary.

guiSetStop is an integer, not a pointer, so I am
afraid it is necessary (well, due to it being a
#define and its value currently being 0 it actually
isn't necessary, but semantically it is better to
leave it).