[MPlayer-cvslog] r33741 - in trunk: gui/interface.c gui/interface.h gui/win32/interface.c libvo

Ingo Brückl ib at wupperonline.de
Mon Jun 27 19:27:12 CEST 2011


Reimar Döffinger wrote on Mon, 27 Jun 2011 17:38:28 +0200:

> On Mon, Jun 27, 2011 at 04:04:13PM +0200, ib wrote:
>> Author: ib
>> Date: Mon Jun 27 16:04:13 2011
>> New Revision: 33741
>>
>> Log:
>> Rename guiGetEvent type guiSetVideo guiSetVideoWindow.

> Well, I guess it is rather a Setup/Init functionality,
> but whatever name you prefer.

I'm currently struggeling with quite some identifiers having strange (i.e.
misleading) names. In my first attempt to make things more comprehensible I
might not always find the best names.

guiGetEvent() is a good example. It mostly *sets* something and it hasn't too
much to do with events. It rather is a communication with/to the gui, i.e.
something like guiComm(), guiCall() or simply gui() might be preferable.

Ingo


More information about the MPlayer-cvslog mailing list