[MPlayer-cvslog] r33777 - in trunk/gui: interface.c ui/gtk/equalizer.c

[Diego Biurrun]

On Thu, Jun 30, 2011 at 10:30:54AM +0200, Ingo Brückl wrote:
> Diego Biurrun wrote on Wed, 29 Jun 2011 20:35:20 +0200:
> 
> > BTW, I'd appreciate git-style "gui:" prefixes for your GUI commits.
> 
> I don't think much of it unless it has become a development rule.
> 
> It hardly is possible to clearly categorize all commits and the changed files
> are listed anyway. There cannot be all information available in the commit
> message.

Strangely, I never have a problem categorizing your commits, I'd label
them all as "gui:". :)

> > Didn't you run all of the GUI through uncrustify already?
> 
> Until now I only did that for the files I'm currently revising / working on,
> i.e. whenever I turned towards a new file I did that one-shot formatting.
> 
> But since these big, one-shot formattings didn't seem to be a winner
> (although they were a good starting point for me) I might merely uncrustify
> the remaining files soon and do the cosmetic formatting (like newlines,
> comments, reordering etc.) one by one afterwards, if that way of proceeding
> is preferred.

I say go for it.

Diego