[MPlayer-cvslog] r33003 - trunk/gui/bitmap.c

[Reimar Döffinger]

On Wed, Mar 02, 2011 at 06:42:06PM +0100, ib wrote:
> Author: ib
> Date: Wed Mar  2 18:42:06 2011
> New Revision: 33003
> 
> Log:
> Use appropriate declaration for array indices.
> 
> Modified:
>    trunk/gui/bitmap.c
> 
> Modified: trunk/gui/bitmap.c
> ==============================================================================
> --- trunk/gui/bitmap.c	Wed Mar  2 18:38:59 2011	(r33002)
> +++ trunk/gui/bitmap.c	Wed Mar  2 18:42:06 2011	(r33003)
> @@ -120,7 +120,7 @@ static int pngRead(unsigned char *fname,
>  static int conv24to32(txSample *bf)
>  {
>      unsigned char *tmpImage;
> -    int i, c;
> +    unsigned int i, c;

unsigned isn't more or less appropriate generally.
There are arguments for either one, though I guess the only
one of those that is undisputable is that "int" is shorter
than "unsigend int" :-)