[MPlayer-cvslog] r32970 - in trunk: Makefile mp_strings.c mp_strings.h

[Clément Bœsch]

On Sun, Mar 06, 2011 at 04:04:08PM +0100, Diego Biurrun wrote:
> On Sat, Feb 26, 2011 at 12:55:03PM +0100, cboesch wrote:
> > 
> > Log:
> > Add mp_strings.c with mp_asprintf function.
> > 
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ trunk/mp_strings.c	Sat Feb 26 12:55:02 2011	(r32970)
> > @@ -0,0 +1,50 @@
> > +
> > +#include <stdlib.h>
> > +#include <stdarg.h>
> > +#include <stdio.h>
> > +#include "mp_strings.h"
> 
> nit: Please add an empty line between system and local headers.
> 

Sorry, you already mentionned it iirc, but I certainly got confused with
the different patches.

> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ trunk/mp_strings.h	Sat Feb 26 12:55:02 2011	(r32970)
> > @@ -0,0 +1,26 @@
> > +
> > +#ifndef MPLAYER_MP_STRINGS_H
> > +#define MPLAYER_MP_STRINGS_H
> > +
> > +char *mp_asprintf(const char *fmt, ...);
> > +
> > +#endif /* !MPLAYER_MP_STRINGS_H */
> 
> The '!' makes no sense IMO and we don't have it in other places.
> 

Fixed too. I used to do it a long time ago, so I added it without
noticing.

-- 
Clément B.