[MPlayer-cvslog] r33059 - trunk/gui/mplayer/gui_common.c

Ingo Brückl ib at wupperonline.de
Wed Mar 9 14:01:20 CET 2011


Clément Boesch wrote on Wed, 9 Mar 2011 00:07:24 +0100:

> Btw, note that it seems this function can be made static.

Oh, thanks for mentioning. I forgot to check this.

>> That's up to the compiler. ;-)

> Up to the compiler to explain the code to the developer? :P

No, I meant the optimization.

I will change all the awkward usages of strlen() some time, and as there are
some of them in for loops, I will find it easily then.

> Not sure to get your point. I was just stating that it's not that clear
> for the developer to know whether the call is needed or not.

Yeah, seems that we somehow talked past each other, but now I got your point.

Ingo


More information about the MPlayer-cvslog mailing list