[MPlayer-cvslog] r33091 - trunk/gui/mplayer/gtk/gtk_menu.c

[Ingo Brückl]

Reimar Döffinger wrote on Mon, 21 Mar 2011 18:39:37 +0100:

>> -      for ( i=0;i < guiIntfStruct.VCDTracks;i++ )
>> +      for ( i=1;i < guiIntfStruct.VCDTracks;i++ )

> That seems wrong. If there are e.g. two tracks you'll add only one menu
> entry now?

The first track of a normal VCD contains a file system, thus the data tracks
start with the 2nd one. STREAM_CTRL_GET_NUM_CHAPTERS returns the number of
data tracks plus the file system track and thus is (and was) by 1 too large.

I've extensively tested VCD functions. Until now, a non-existing last track
could be selected in a variety of ways, which is corrected now.

According to the VCD documentation special VCDs without a file system track
are said to exist. With these, there would be no menu entry (which shouldn't
be a big problem), but on the other hand I'm quite sure that lots of the
other, existing VCD code will somehow or other fail on them, too. I couldn't
create such a VCD, but if anyone knows where I can get an image or how to
create it, I'd like to check such a VCD and fix arising bugs.

Ingo