[MPlayer-cvslog] r33352 - in trunk/gui: cfg.c cfg.h interface.c

[Ingo Brückl]

Reimar Döffinger wrote on Tue, 3 May 2011 19:46:41 +0200:

> On 3 May 2011, at 15:19, ib <subversion at mplayerhq.hu> wrote:
>> @@ -417,6 +421,13 @@ void guiDone(void)
>> // GUI's own abortions during (and before) guiInit().
>> void guiExit(int how)
>> {
>> +    if (!initialized || (how == DONE)) {

> You should really comment this a bit, it is not at all obvious.

>> +        if (gui_conf) {
>> +            m_config_free(gui_conf);
>> +            gui_conf = NULL;
>> +        }
>> +    }

Do you mean something like

  // if either guiInit() isn't yet finished, i.e. GUI not yet initialized,
  // or it's a call from guiDone(), i.e. GUI gets normally terminated
  if (!initialized || (how == DONE))

or to comment *what* is done?

On the other hand, there is a big NOTE (not only to myself) prefacing the
function.

Ingo