[MPlayer-cvslog] r33465 - trunk/configure

Diego Biurrun diego at biurrun.de
Tue May 17 02:09:17 CEST 2011


On Sun, May 15, 2011 at 08:42:59PM +0200, cehoyos wrote:
> 
> Log:
> Fix false positives when auto-detecting live555 library.

What sort of false positives?

> --- trunk/configure	Fri May 13 03:13:32 2011	(r33464)
> +++ trunk/configure	Sun May 15 20:42:59 2011	(r33465)
> @@ -6787,13 +6787,14 @@ if test "$_live" = auto  && test "$netwo
>  
>    _live=no
>    for I in $extra_cflags "-I$_libdir/live" "-I/usr/lib/live" "-I/usr/lib64/live" "-I/usr/local/live" "-I/usr/local/lib/live" ; do
> -    cxx_check $I/liveMedia/include $I/UsageEnvironment/include $I/groupsock/include &&
>          _livelibdir=$(echo $I| sed s/-I//) &&
> +    cxx_check $I/liveMedia/include $I/UsageEnvironment/include $I/BasicUsageEnvironment/include $I/groupsock/include $_livelibdir/BasicUsageEnvironment/libBasicUsageEnvironment.a $_livelibdir/UsageEnvironment/libUsageEnvironment.a &&
>        extra_ldflags="$_livelibdir/liveMedia/libliveMedia.a \
>                   $_livelibdir/groupsock/libgroupsock.a \
>                   $_livelibdir/UsageEnvironment/libUsageEnvironment.a \

This leaves behind a particularly ugly case of bad indentation.
Please just fix such things right away in the same commit
instead of leaving it for later or never.

Diego


More information about the MPlayer-cvslog mailing list