[MPlayer-cvslog] r33448 - trunk/gui/mplayer/gui_common.c

[Ingo Brückl]

Reimar Döffinger wrote on Sun, 22 May 2011 20:02:45 +0200:

> I missed that the variables are all unsigned, why not
> int64_t duration = fileh->play_duration;
> duration = FFMAX(duration - 10000*fileh->preroll, 0);
> asf->movielength=duration/10000000.0;

Nah. Why casting to int64_t only to be able to use FFMAX to figure out which
of two values is greater?

If you don't like the if-else, maybe a ?:-one-liner is more appealing to you?

Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asfheader.patch
Type: text/x-diff
Size: 964 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20110522/688e9cb7/attachment-0001.bin>