[MPlayer-cvslog] r33516 - trunk/stream/stream_cue.c

[Ivan Kalvachev]

On 5/29/11, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Sun, May 29, 2011 at 03:11:03PM +0300, Ivan Kalvachev wrote:
>> On 5/29/11, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
>> > On Sun, May 29, 2011 at 02:49:48PM +0300, Ivan Kalvachev wrote:
>> >> On 5/29/11, reimar <subversion at mplayerhq.hu> wrote:
>> >> > Author: reimar
>> >> > Date: Sun May 29 13:47:18 2011
>> >> > New Revision: 33516
>> >> >
>> >> > Log:
>> >> > Ensure 0-termination even if line does not start with FILE "
>> >>
>> >> What's wrong with you?
>> >> Are you doing stupid commit war?
>> >
>> > Sorry if I stepped on your toes, I just saw I few more issues and
>> > though it simpler to just fix them one by one rather than trying
>> > to analyze your all-in-one patch.
>> > Is that really a problem?
>>
>> This commit is 1/3 of my patch. You already committed another 1/3 of it.
>> It is just obfuscated by your earlier changes.
>>
>> If you really want other developers to work on this project you need
>> to respect their work. Don't give me the crap that you haven't read my
>> patch because it is too long or complicated.
>
> No I won't, you're right.
> It wasn't my intention to obfuscate your contribution.
> While I didn't directly use your patch I had read it before
> and was certainly influenced by it.
> I was too lazy though to think about which parts to attribute and how.
> I am very sorry, I just didn't expect this to be such a big thing.
> What would be an acceptable way for you to fix this? Edit the commit
> messages?

Yes, thank you. And be a lot more careful in future.

If you wanted me to commit my patch so that you can fix the other
things you could have just asked me. If you can't wait, you can try to
find me on irc.