[MPlayer-cvslog] r34302 - trunk/configure

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Nov 7 19:41:36 CET 2011

On Mon, Nov 07, 2011 at 07:29:53PM +0100, Diego Biurrun wrote:
> On Sat, Nov 05, 2011 at 02:47:51PM +0100, cehoyos wrote:
> > 
> > Log:
> > Define HAVE_YASM etc. not only for x86.
> ... and this you did - why?  YASM is x86-only.

Because it is valid to use
if (HAVE_YASM) some_init();
in non-x86 code (we use that kind of thing in other
places to avoid an #if).
In that specific case the file is diracdsp.c
And now I'd like to add that please think twice before
committing something with a one-line commit message.
Because that most likely means you forgot to mention
something that would have made it a lot easier to understand
_why_ you are doing the change - this one really is not

More information about the MPlayer-cvslog mailing list