[MPlayer-cvslog] r34352 - trunk/configure

Diego Biurrun diego at biurrun.de
Thu Nov 17 18:26:58 CET 2011


On Wed, Nov 16, 2011 at 07:55:47PM +0100, Reimar Döffinger wrote:
> On Wed, Nov 16, 2011 at 12:14:23PM +0100, diego wrote:
> > 
> > Log:
> > configure: add HAVE_OS2THREADS to config.h for libavformat
> > 
> > --- trunk/configure	Wed Nov 16 10:54:29 2011	(r34351)
> > +++ trunk/configure	Wed Nov 16 12:14:23 2011	(r34352)
> > @@ -8695,6 +8695,7 @@ $def_yasm
> >  #define HAVE_LDBRX 0
> >  #define HAVE_LOCALTIME_R 0
> >  #define HAVE_MAPVIEWOFFILE 0
> > +#define HAVE_OS2THREADS 0
> 
> I know you can't test it and it's not exactly a lot of users,
> but shouldn't this rather be
> #ifdef __OS2__
> #define HAVE_OS2THREADS 1
> #else
> #define HAVE_OS2THREADS 0
> #endif
> ?

It should be tested in configure, like everything in that stanza.
I really cannot be bothered to keep duplicating an external
configure (badly), much less for stuff I cannot test.

Diego


More information about the MPlayer-cvslog mailing list