[MPlayer-cvslog] r34860 - in trunk: libmpcodecs/vd_ffmpeg.c libmpcodecs/vd_mpegpes.c libmpcodecs/vd

[Reimar Döffinger]

On Sun, Apr 15, 2012 at 08:03:20PM +0200, Ingo Brückl wrote:
> > Author: reimar
> > Date: Sun Apr 15 17:01:09 2012
> > New Revision: 34860
> 
> mplayer.c: In function 'update_video':
> mplayer.c:2429: warning: 'flush' may be used uninitialized in this function
> 
> Did you notice this message?

No, thanks for noticing.

> > Modified: trunk/mplayer.c
> > ==============================================================================
> > +++ trunk/mplayer.c     Sun Apr 15 17:01:09 2012        (r34860)
> > @@ -2425,6 +2426,7 @@ static double update_video(int *blit_fra
> >          int full_frame;
> >
> >          do {
> > +            int flush;
> >              current_module = "video_read_frame";
> >              frame_time     = sh_video->next_frame_time;
> >              in_size = video_read_frame(sh_video,
> > &sh_video->next_frame_time,
> > @@ -2441,6 +2443,11 @@ static double update_video(int *blit_fra
> >                  mpctx->stream->eof = 0;
> >              } else
> >  #endif
> > +            flush = in_size < 0 && mpctx->d_video->eof;
> > +            if (flush) {
> > +                start = NULL;
> > +                in_size = 0;
> > +            }
> >              if (in_size < 0)
> >                  return -1;
> >              if (in_size > max_framesize)
> 
> I don't know nothing about what this is all about, but the "else" in the
> CONFIG_DVDNAV block grabs the "flush = in_size < 0 && mpctx->d_video->eof;".

It is kind of a special-case mess to display the still
frames in DVD menus.
It seems there's a whole lot of stuff broken again around that anyway.
I'll fix that one first though.