[MPlayer-cvslog] r34860 - in trunk: libmpcodecs/vd_ffmpeg.c libmpcodecs/vd_mpegpes.c libmpcodec

[Reimar Döffinger]

On Mon, Apr 16, 2012 at 12:06:47PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sun, 15 Apr 2012 23:01:32 +0200:
> 
> > On Sun, Apr 15, 2012 at 08:03:20PM +0200, Ingo Brückl wrote:
> >> > Author: reimar
> >> > Date: Sun Apr 15 17:01:09 2012
> >> > New Revision: 34860
> >>
> >> mplayer.c: In function 'update_video':
> >> mplayer.c:2429: warning: 'flush' may be used uninitialized in this function
> >>
> >> Did you notice this message?
> 
> > No, thanks for noticing.
> 
> You're welcome.
> 
> BTW, this again raises a (one year old) question why we don't use silent
> compiling which helps spotting these messages more easily. (For the GUI
> I personally am using even far stricter warning options.) I don't mind
> continuing to patch these for me locally but I think that these might be
> of benefit for all developers. At least they don't worsen anything.
> 
> Ingo

> Prettify make output.
> 
> By default, make gives brief compiling messages.
> For full command echoing, add V=1 to make.
> 
> 
> Index: Makefile
> ===================================================================
> --- Makefile	(revision 33134)
> +++ Makefile	(working copy)
> @@ -21,6 +21,14 @@
> 
>  include config.mak
> 
> +ifdef V
> +P = @\#
> +Q =
> +else
> +P = @
> +Q = @
> +endif

The FFmpeg approach is nicer and avoids having to change all the rules.
Though it will require a few hacks/rule changes, too.