[MPlayer-cvslog] r35691 - trunk/libmpcodecs/vf_ass.c

[Diego Biurrun]

On Mon, Dec 17, 2012 at 11:20:14PM +0800, Xidorn Quan wrote:
> On Mon, Dec 17, 2012 at 10:20 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Mon, Dec 17, 2012 at 02:34:58AM +0100, upsuper wrote:
> > >
> > > Log:
> > > Cosmetic: reindent & move defines out of function
> > >
> > > --- trunk/libmpcodecs/vf_ass.c        Sun Dec 16 14:49:36 2012        (r35690)
> > > +++ trunk/libmpcodecs/vf_ass.c        Mon Dec 17 02:34:58 2012        (r35691)
> > > @@ -419,21 +419,6 @@ static void render_frame_yuv420p(vf_inst
> > > -
> > >  #define CHECK_16_ALPHA \
> > >              "cmpl   $-1,     0(%[alpha], %[j], 1) \n\t" \
> > >              "jne    2f \n\t"                            \
> > > @@ -485,6 +470,21 @@ static void render_frame_yuv420p_sse4(vf
> > >              "paddb      %%xmm4, %%xmm1 \n\t"                    \
> > >              "movdqu     %%xmm1, (%%"REG_D", %[j], 1) \n\t"
> >
> > You left the macros with, seemingly random, 16 space indentation.
> 
> I found that asm macros in vf_yadif.c use 12 space indentation, so I used it.
> Should them be 4 space indent as well?

Don't use old crufty files as reference, you can find negative examples
for almost anything in our codebase.  Just use 4 spaces indentation.
If at all, use new files or freshly reindented files as reference.

Diego