[MPlayer-cvslog] r34664 - in trunk/gui: cfg.c win32/wincfg.c

[Reinhard Tartler]

On Fri, Feb 10, 2012 at 1:51 PM, Ingo Brückl <ib at wupperonline.de> wrote:
> Reimar Döffinger wrote on Thu, 9 Feb 2012 21:23:28 +0100:
>
>> On Thu, Feb 09, 2012 at 01:52:10PM +0100, ib wrote:
>>> +#define GUI_CONFIGURATION "gui.conf"
>>> +#define GUI_HISTORY       "gui.history"
>>> +#define GUI_PLAYLIST      "gui.pl"
>>> +#define GUI_URLLIST       "gui.url"
>
>> Not important but usually I think it's better to avoid defines and use
>> e.g.
>> static const char gui_configuration[] = "gui.conf";
>> etc.
>
> Is there a general advantage or only when using the definition more than
> once?

generally, macros manipulate the token stream and cannot be
type-checked by various tools such as the compiler, etc.

-- 
regards,
    Reinhard