[MPlayer-cvslog] r34546 - in trunk: DOCS/xml/de/skin.xml DOCS/xml/en/skin.xml gui/app.c gui/app.h gui/interface.c gui/ui/main.c gui/win32/skinload.c gui/win32/skinload.h

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Jan 12 20:20:18 CET 2012

On Thu, Jan 12, 2012 at 03:21:56PM +0100, ib wrote:
> -        if (appFindItem(msg))
> +        if ((msg == evMenu) || appFindItem(msg))

Nit: At least I don't like extra () around == much

> +   case evMenu:
> +        /*if (guiApp.menuIsPresent)   NOTE TO MYSELF: Not before mouse over and
> +         {                                            cursor keys will work there.

At least I can't parse that comment, I think the grammar is wrong.
Sure, it's mostly a comment to yourself, but it gets really embarrassing
if by the time you look at it again even you don't understand it anymore

More information about the MPlayer-cvslog mailing list