[MPlayer-cvslog] r34582 - in trunk: mencoder.c mplayer.c sub/ass_mp.c sub/ass_mp.h

[Reimar Döffinger]

On Thu, Jan 19, 2012 at 07:01:09PM -0500, compn wrote:
> On Fri, 20 Jan 2012 00:20:38 +0100 (CET), reimar wrote:
> >Modified:
> >   trunk/mencoder.c
> >   trunk/mplayer.c
> >   trunk/sub/ass_mp.c
> >   trunk/sub/ass_mp.h
> >
> >Modified: trunk/mencoder.c
> >+#ifdef CONFIG_ASS
> >+  // must be before demuxer open, since the settings are
> >+  // used in generating the ASSTrack
> >+  if (ass_enabled && ass_library)
> >+    ass_mp_reset_config(ass_library);
> >+#endif
> >+
> 
> 
> >Modified: trunk/mplayer.c
> >+#ifdef CONFIG_ASS
> >+    // must be before demuxer open, since the settings are
> >+    // used in generating the ASSTrack
> >+    if (ass_enabled && ass_library)
> >+        ass_mp_reset_config(ass_library);
> >+#endif
> 
> can duplication fit in mp_common? not that it matters much... (thanks
> for working on mencoder)

Yes, that kind of thing sure should be done.
There are probably bigger issues than just those 2 lines though.