[MPlayer-cvslog] r35452 - trunk/gui/util/bitmap.c

Erik Auerswald auerswal at unix-ag.uni-kl.de
Sun Nov 25 17:31:38 CET 2012


Hi,

On Fri, Nov 23, 2012 at 11:15:43AM +0100, ib wrote:
> Author: ib
> Date: Fri Nov 23 11:15:43 2012
> New Revision: 35452
> 
> Log:
> Don't use signed variable for file length.
> 
> Modified:
>    trunk/gui/util/bitmap.c
> 
> Modified: trunk/gui/util/bitmap.c
> ==============================================================================
> --- trunk/gui/util/bitmap.c	Fri Nov 23 11:04:26 2012	(r35451)
> +++ trunk/gui/util/bitmap.c	Fri Nov 23 11:15:43 2012	(r35452)
> @@ -47,7 +47,7 @@
>  static int pngRead(const char *fname, guiImage *img)
>  {
>      FILE *file;
> -    long len;
> +    size_t len;

Shouldn't this be off_t? I don't think it really matters, but off_t feels
more correct.

Erik


More information about the MPlayer-cvslog mailing list