[MPlayer-cvslog] r35203 - in trunk/libmpcodecs: vf_delogo.c vf_unsharp.c

[Reimar Döffinger]

On 20 Sep 2012, at 00:05, Ingo Brückl <ib at wupperonline.de> wrote:
> Reimar Döffinger wrote on Wed, 19 Sep 2012 21:41:20 +0200:
> 
>> On Wed, Sep 19, 2012 at 09:02:14PM +0200, Ingo Brückl wrote:
>>>> static int put_image( struct vf_instance *vf, mp_image_t *mpi, double pts) {
>>>>     mp_image_t *dmpi = mpi->priv;
>>>> +    mpi->priv = NULL;
>>>> 
>>>>     if( !(mpi->flags & MP_IMGFLAG_DIRECT) )
>>>>         // no DR, so get a new image! hope we'll get DR buffer:
>>> 
>>> This makes 'mplayer -vf-add unsharp=l7x7:1.7 <file>' crash with SIGSEGV after
>>> the file has been played (applies to '-vf-add delogo' as well).
> 
>> Doesn't crash for me, neither with H.264 nor MPEG-4 content.
>> I'm afraid I'll need some more information to debug that.
> 
> Does this help?
> 
>  Beenden... (Dateiende erreicht)
>  ==21510== Invalid free() / delete / delete[] / realloc()
>  ==21510==    at 0x4024A61: free (vg_replace_malloc.c:446)
>  ==21510==    by 0x5ABCC1B: free_mem (in /lib/libc-2.9.so)
>  ==21510==    by 0x5ABC729: __libc_freeres (in /lib/libc-2.9.so)
>  ==21510==    by 0x401E47A: _vgnU_freeres (vg_preloaded.c:62)
>  ==21510==    by 0x5A49E03: _Exit (in /lib/libc-2.9.so)
>  ==21510==    by 0x808036A: exit_player_with_rc (in /usr/bin/mplayer)
>  ==21510==  Address 0x5b2b3d0 is not stack'd, malloc'd or (recently) free'd

Not so much since valgrind doesn't work for me currently (gcc 4.7 inserts 3dnow prefetch instructions an valgrind doesn't support 3dnow - this is particular fun since AMD has announced plans to remove 3dnow support in future CPUs)

> If not, please tell me how I can assist.

But are you sure it is exactly this commit, and also that there is no other valgrind error before?
Because that is a crash deep in the exit deallocation code in the libc, I can't see how nulling some field in a filter should be able to cause a crash there.