[MPlayer-cvslog] r36403 - in trunk/libvo: vo_gl.c x11_common.c

[Reimar Döffinger]

On 05.08.2013, at 19:01, Ingo Brückl <ib at wupperonline.de> wrote:
>> Author: reimar
>> Date: Mon Aug  5 18:48:56 2013
>> New Revision: 36403
> 
>> Log:
>> On X11 use root window as "hidden" window instead of
>> an unmaped window.
> 
>> Modified: trunk/libvo/x11_common.c
>> =========================================================================
>> +++ trunk/libvo/x11_common.c    Mon Aug  5 18:48:56 2013        (r36403)
>> @@ -1100,6 +1100,16 @@ void vo_x11_create_vo_window(XVisualInfo
>>                              Colormap col_map,
>>                              const char *classname, const char *title)
>> {
>> +  if (flags & VOFLAG_HIDDEN) {
>> +    // unmapped windows cause lots of issues, in particular
>> +    // -geometry might be ignore when finally mapping them etc.
>> +    if (vo_window == None)
>> +      vo_window = mRootWin;
>> +    window_state = VOFLAG_HIDDEN;
>> +    goto final;
>> +  } else if (vo_window == mRootWin && (window_state & VOFLAG_HIDDEN)) {
>> +    vo_window = None;
>> +  }
> 
> Shouldn't that be behind the if-(WinID >= 0)-block?

I guess for WinID >= 0 we could just ignore the hidden flag, but on the other hand there's some value in having consistent behaviour.
If you have strong preferences I don't mind changing it, but I think it is ok as it is.