[MPlayer-cvslog] r35834 - trunk/configure

[Alexander Strasser]

Diego Biurrun wrote:
[...]
> 
> a) Patching libdvdcss in order to silence a harmless warning in another
>    upstream library copy is not worth it.

  This is very disputable.

> b) libdvdcss will likely be changed to make all of this moot.

  Here you silently changed your opinion. Suddenly the fixing at the root
stuff rightly vanished. If the CPP macro gets completely dropped in libdvdcss
it is fixing the symptoms at the leaf. Your change in configure is just a
hack because it is just favouring libdvdcss over lavf but not solving the
inherent problem.
  
SUMMARY

  The imported copy was fixed months ago and worked fine. Your 2 commits just
introduced a warning, without solving any problem.

  So to make it really short now:

  1. I will *not* continue playing your game here!
     Thus I will *not* reply to your flames.
  2. If you don't do it in 3 days I will revert both r35834 + r35835 myself.
  3. Note that both changed #ifdef-lines in our libdvdcs copy will disappear
     on the next synch to upstream if they decide to drop that macro completely.
     So in that case r35834 + r35835 will be obsolete anyway.


  Alexander