[MPlayer-cvslog] r35939 - trunk/configure

Reimar Döffinger Reimar.Doeffinger at gmx.de
Tue Mar 12 20:19:37 CET 2013


On Sun, Mar 10, 2013 at 07:26:15PM +0200, Ivan Kalvachev wrote:
> On 3/10/13, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:
> > This patch certainly doesn't break anything more than before.
> > It only changes the case where we would end up with
> > "-lXvMC -l" to just "-lXvMC".
> > Which in addition can only happen if used with --enable-xvmc
> > Maybe it's not actually useful, but I can't see how it would be wrong.
> 
> Do you have such case, because I don't see how is that possible.
> 
> The detection DOES run for --enable-xvmc ($_xvmc != no) and the
> _xvmclib is updated on successful detect. Unsuccessful detect disables
> xvmc.

Sorry, I admit I don't know.
Ages ago a user ended up with linking issues due to a lonely "-l" on
the command line.
I think it came from that configure check, but I'm not completely sure.
I just decided that this additional sanity check (which I had lying
around in my local tree all that time) shouldn't really hurt anything
and kind of makes sense.
If it bothers you feel free to revert it, I mostly wanted to get
rid of unnecessary diffs in my local tree and considered committing
it the better way that reverting locally.


More information about the MPlayer-cvslog mailing list