[MPlayer-cvslog] r37176 - in trunk: gui/interface.c help/help_mp-de.h help/help_mp-en.h

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Apr 26 13:24:30 CEST 2014

On Thu, Apr 24, 2014 at 03:51:20PM +0200, ib wrote:
> +                do
> +                    memcpy(&vf_settings[i], &vf_settings[i + 1], sizeof(m_obj_settings_t));
> +                while (vf_settings[++i].name);

IMHO there is no good reason to leave out the {} for do-while.
They don't need additional lines, and make the code less confusing
(because without distinguishing a while and do-while loop is less
obvious for example).
Another question is if it wouldn't make more sense to first
figure out how many to move and then use memmove to copy all at once...

More information about the MPlayer-cvslog mailing list