[MPlayer-cvslog] r36774 - in trunk/libvo: gl_common.c gl_common.h gl_compat.h vo_gl.c

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Feb 5 15:27:04 CET 2014


On 5 February 2014 14:21:57 CET, Guillaume POIRIER <poirierg at gmail.com> wrote:
>Hello,
>
>On Sat, Feb 1, 2014 at 4:13 PM, reimar <subversion at mplayerhq.hu> wrote:
>> Author: reimar
>> Date: Sat Feb  1 16:13:00 2014
>> New Revision: 36774
>
>> +static GLvoid *wrap_glMapBuffer(GLenum target, ptrdiff_t offset,
>ptrdiff_t range, unsigned flags) {
>
>
>This change tiggers this kind of error at compile time:
....
>As I'm certain that you have not committed somthing that didn't
>compile,

That is not a valid assumption in general, but this case I did test it compiling on Debian before committing.

> do you know if stddef.h may only be necessary for OSX, or
>should it be included in all configs?

Seems this is my fault, I assumed it is in stdint.
But it seems stddef is necessary for correct code, so yes it should be included in all cases, and preferably grouped with the standard headers like stdint.



More information about the MPlayer-cvslog mailing list