[MPlayer-cvslog] r36878 - trunk/configure

[Reimar Döffinger]

On Tue, Feb 18, 2014 at 03:04:39PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Tue, 18 Feb 2014 14:04:36 +0100:
> 
> > On 18 February 2014 12:42:26 CET, "Ingo Brückl" <ib at wupperonline.de> wrote:
> >>
> >>Actually we also need libavcodec/allcodecs.c, libavformat/allformats.c
> >>and libavfilter/allfilters.c
> 
> > No, worked just fine for me without.
> 
> Well, at least libavcodec/allcodecs.c seems necessary:
> 
>   Error: The GUI requires libavcodec with PNG support (needs zlib).

That check is wrong, it should only apply to ffmpeg_a = yes case.
If we use a precompiled FFmpeg we can't properly check if it will
support PNG or not, and checking if an FFmpeg we _would_ build ourselves
_would_ support PNG when we use something else is just nonsense.

> > Of course configure prints a lot of crap if they are missing, but
> > doesn't fail and shouldn't cause issues.
> 
> Do you mind silencing?

Why not just appending 2>/dev/null ?
Though maybe that is a bit overkill.
But even your variant would hide if they only are missing by accident...
I'm not sure if it wouldn't be better to skip only if ffmpeg_a = no,
but that has other issues.
So, I don't know. Feel to change however you think is best, in case
you have an opinion.