[MPlayer-cvslog] r36904 - trunk/stream/vcd_read_os2.h

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Feb 23 15:57:08 CET 2014

On 23 February 2014 15:35:31 CET, komh <subversion at mplayerhq.hu> wrote:
>Author: komh
>Date: Sun Feb 23 15:35:30 2014
>New Revision: 36904
>vcd_read_os2.h: replace calloc() with _calloc() only in vcd_read_os2.h

I meant: why use a define at all?
I don't think there is any guarantee that it is safe to override calloc via a define at all, plus defines have loads of issues.
Why not just put an ifdef around the only calloc that causes issues?
That is, unless you want to go even further and remove the sector data array completely from the context and just put in on the stack in the read function, then you'd need no ifdef at all (but should add a comment why)

More information about the MPlayer-cvslog mailing list