[MPlayer-cvslog] r36944 - in trunk/gui/win32: interface.c playlist.c playlist.h

Ingo Brückl ib at wupperonline.de
Tue Feb 25 19:39:10 CET 2014

Reimar Döffinger wrote on Tue, 25 Feb 2014 19:01:27 +0100:

>> @@ -501,6 +501,8 @@ static unsigned __stdcall GuiThread(void
>>  {
>>      MSG msg;
>> +    (void) param;

> This is a bit ugly and might not work in all compilers.

I'd say it'll work on most (all?) compilers. Yes, it's ugly.

> I think using av_unused on the parameter would be nicer,

I don't mind using it, but it would be nice if gcc would warn if such a
parameter *will* be used later. (This is the only thing I dislike about the
(void) solution. It'll look strange if you forget to remove it later. With
av_unused it'll even look stranger.)


More information about the MPlayer-cvslog mailing list