[MPlayer-cvslog] r36765 - trunk/help/help_check.sh

Ingo Brückl ib at wupperonline.de
Fri Jan 31 15:08:06 CET 2014

Alexander Strasser wrote on Fri, 31 Jan 2014 13:29:39 +0100:

>> -  sed -n "s:^[ \t]*#define[ \t]\+\([0-9A-Za-z_]\+\)[ \t].*:strdup(\1);:p" "$h" >> ${CHECK}.c
>> +  sed -n "s:^[ \t]*#define[ \t]\+\([0-9A-Za-z_]\+\)\(.*\):strdup(\1);:p" "$h" >> ${CHECK}.c

>   Pardon me, but I wonder why you added the 2nd pair of parens?

Sometimes you don't to see the wood for the trees.

>   I mean why not instead:

> +  sed -n "s:^[ \t]*#define[ \t]\+\([0-9A-Za-z_]\+\).*:strdup(\1);:p" "$h" >> ${CHECK}.c


>   Doesn't hurt the way it is, just consider me nitpicking about readability.

I greatly appreciate having a look at my patches.



More information about the MPlayer-cvslog mailing list