[MPlayer-cvslog] r36976 - trunk/configure

[Reimar Döffinger]

On 05.03.2014, at 20:21, Ingo Brückl <ib at wupperonline.de> wrote:
> Reimar Döffinger wrote on Wed, 5 Mar 2014 19:59:54 +0100:
> 
>> On Wed, Mar 05, 2014 at 07:53:09PM +0100, Ingo Brückl wrote:
>>>> Author: reimar
>>>> Date: Wed Mar  5 19:33:20 2014
>>>> New Revision: 36976
>>> 
>>>> Log:
>>>> Refine compilation against shared FFmpeg.
>>> 
>>>> @@ -7098,6 +7098,7 @@ if test "$ffmpeg_so" = auto ; then
>>>> fi
>>>> 
>>>> if test "$ffmpeg" = yes; then
>>>> +  header_check libavutil/x86/asm.h || die "libavutil/x86/asm.h header is required for shared FFmpeg"
>>> 
>>> "... is required for FFmpeg"
>>> 
>>> For the static version, only the existence of the ffmpeg directory has been
>>> checked so far, so if the header is missing, it's missing for both methods,
>>> isn't it?
> 
>> Yes, though it kind of shouldn't happen, plus more than just that
>> header is required for the static version.
> 
> The message doesn't say that only asm.h is required.

No, but the fact that it only mentions it implies it.

>> So I'm not sure leaving "shared" out is going to improve things.
> 
> For someone trying to compile with a static FFmpeg and a bad checkout, it
> probably would be less confusing.
> 
>> I considered putting it under the ffmpeg_so case,
> 
> Sounds reasonable to me.
> 
>> but this way it receives some extra testing.
> 
> Which (I qoute) "kind of shouldn't happen".

If the test gets broken it is noticeable when configuring normally, that's the point.