[MPlayer-cvslog] r37757 - in trunk: command.c libmpcodecs/ad_faad.c libmpcodecs/ve_raw.c libvo/vo_fbdev.c libvo/vo_xover.c stream/realrtsp/rmff.c

[reimar]

Author: reimar
Date: Sat Feb 20 12:32:40 2016
New Revision: 37757

Log:
Explicitly mark intentional case fallthroughs.

Should avoid Coverity warnings and make
intent a little bit more obvious.

Modified:
   trunk/command.c
   trunk/libmpcodecs/ad_faad.c
   trunk/libmpcodecs/ve_raw.c
   trunk/libvo/vo_fbdev.c
   trunk/libvo/vo_xover.c
   trunk/stream/realrtsp/rmff.c

Modified: trunk/command.c
==============================================================================
--- trunk/command.c	Sat Feb 20 12:23:46 2016	(r37756)
+++ trunk/command.c	Sat Feb 20 12:32:40 2016	(r37757)
@@ -1894,6 +1894,7 @@ static int mp_property_sub_forced_only(m
     case M_PROPERTY_SET:
         if (!arg)
             return M_PROPERTY_ERROR;
+        // fallthrough
     case M_PROPERTY_STEP_UP:
     case M_PROPERTY_STEP_DOWN:
         m_property_flag(prop, action, arg, &forced_subs_only);

Modified: trunk/libmpcodecs/ad_faad.c
==============================================================================
--- trunk/libmpcodecs/ad_faad.c	Sat Feb 20 12:23:46 2016	(r37756)
+++ trunk/libmpcodecs/ad_faad.c	Sat Feb 20 12:32:40 2016	(r37757)
@@ -106,8 +106,10 @@ static int init(sh_audio_t *sh)
       switch(sh->samplesize){
 	case 1: // 8Bit
 	  mp_msg(MSGT_DECAUDIO,MSGL_WARN,"FAAD: 8Bit samplesize not supported by FAAD, assuming 16Bit!\n");
+          // fallthrough
 	default:
 	  sh->samplesize=2;
+          // fallthrough
 	case 2: // 16Bit
 	  faac_conf->outputFormat = FAAD_FMT_16BIT;
 	  break;

Modified: trunk/libmpcodecs/ve_raw.c
==============================================================================
--- trunk/libmpcodecs/ve_raw.c	Sat Feb 20 12:23:46 2016	(r37756)
+++ trunk/libmpcodecs/ve_raw.c	Sat Feb 20 12:32:40 2016	(r37757)
@@ -87,6 +87,7 @@ static int set_format(struct vf_instance
 	break;
     case IMGFMT_IF09:
 	mux_v->bih->biPlanes = 4;
+	// fallthrough
     case IMGFMT_YVU9:
 	mux_v->bih->biBitCount = 9;
 	break;

Modified: trunk/libvo/vo_fbdev.c
==============================================================================
--- trunk/libvo/vo_fbdev.c	Sat Feb 20 12:23:46 2016	(r37756)
+++ trunk/libvo/vo_fbdev.c	Sat Feb 20 12:32:40 2016	(r37757)
@@ -502,6 +502,7 @@ static void set_bpp(struct fb_var_screen
     case 32:
         p->transp.offset = 24;
         p->transp.length = 8;
+        // fallthrough
     case 24:
         p->red.offset   = 16;
         p->red.length   = 8;

Modified: trunk/libvo/vo_xover.c
==============================================================================
--- trunk/libvo/vo_xover.c	Sat Feb 20 12:23:46 2016	(r37756)
+++ trunk/libvo/vo_xover.c	Sat Feb 20 12:32:40 2016	(r37757)
@@ -422,6 +422,7 @@ static int control(uint32_t request, voi
     return VO_TRUE;
   case VOCTRL_FULLSCREEN:
     vo_x11_fullscreen();
+    // fallthrough
   case VOCTRL_SET_PANSCAN:
     if ( vo_fs && ( vo_panscan != vo_panscan_amount ) )
       {

Modified: trunk/stream/realrtsp/rmff.c
==============================================================================
--- trunk/stream/realrtsp/rmff.c	Sat Feb 20 12:23:46 2016	(r37756)
+++ trunk/stream/realrtsp/rmff.c	Sat Feb 20 12:32:40 2016	(r37757)
@@ -477,6 +477,7 @@ rmff_header_t *rmff_scan_header_stream(i
     switch (chunk_type) {
       case DATA_TAG:
         chunk_size=18;
+        // fallthrough
       case MDPR_TAG:
       case CONT_TAG:
       case RMF_TAG: