[MPlayer-dev-eng] [PATCH] Yet another batch of warning fixes :->

[Arpi]

Hi,

>  typedef unsigned short  WORD;
> -typedef unsigned int    DWORD;
> -typedef unsigned int    ULONG;
> +typedef unsigned long   DWORD;
> +typedef unsigned long   ULONG;
>  typedef unsigned char   BYTE;

ARGH&*!%^#&*%@*&

it'll break code on 64bit platforms badly

> -		    printf("%.4s ", &c->fcc);
> +		    printf("%.4d ", c->fcc);

heh?
%.4d won't print fourcc but a silly number

> -	*lpFilePart = strrchr(lpFileName, '\\');
> +	lpFilePart = strrchr(lpFileName, '\\');
>      else
> -	*lpFilePart = lpFileName;
> +	lpFilePart = lpFileName;

looks bad

>  #define ADDQUE(xi,xq,in)\
>    xq[xi]=xq[xi+L]=(*in);\
> -  xi=(--xi)&(L-1);
> +  xi=(xi-1)&(L-1);\
> +  xi--;

why?

>      register int16_t* 	end   = in+ao_plugin_data.len/2;
> -    while(in < end) *in=(*in++)>>1;
> +    while(in < end) { *in=(*in)>>1; in++; }

again, why?

> +    InitializeQTML = (OSErr (*)(long))GetProcAddress(handler,
> "InitializeQTML");

WTF is this mess?

> -          uqvq = encoded[pixel_ptr++] + (encoded[pixel_ptr++] << 8);
> +          uqvq = encoded[pixel_ptr+1] + (encoded[pixel_ptr+2] << 8);
> +          pixel_ptr += 2;

i can't understand nor accept such changes

> -//#include <string.h>      // FIXME: conflicts with fs.h
> +#include <string.h>      // FIXME: conflicts with fs.h
                                      ^^^^^^^^^^^^^^^^^^^

and so on

do NOT apply this mess!
there are some good points but mostly broken stuff, and we're after -rc1...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu