[MPlayer-dev-eng] [PATCH] Yet another batch of warning fixes :->

[Dominik Mierzejewski]

On Tuesday, 10 December 2002, Arpi wrote:
> Hi,
> 
> > > >  typedef unsigned short  WORD;
> > > > -typedef unsigned int    DWORD;
> > > > -typedef unsigned int    ULONG;
> > > > +typedef unsigned long   DWORD;
> > > > +typedef unsigned long   ULONG;
> > > >  typedef unsigned char   BYTE;
> > > 
> > > ARGH&*!%^#&*%@*&
> > > 
> > > it'll break code on 64bit platforms badly
> > 
> > Will it? How about uint32_t then? And avifile's loader has those
> what is the problem with int ?

Lots and lots of warnings about incompatible types.

> > defines exactly like in my patch.
> yes and avifile is broken too. anyway avifile duplicates all those
> structs with int (instead of DWORD) in its include/ dir, and us eit for
> non-x86 platforms.

Interesting. I couldn't find it, however. If you could point me to the
right file... :-/
 
> > > > -		    printf("%.4s ", &c->fcc);
> > > > +		    printf("%.4d ", c->fcc);
> > > 
> > > heh?
> > > %.4d won't print fourcc but a silly number
> > 
> > Hmmm. Right, sorry, missed this one (although there's another done right).
> another? where?

One was in loader/dshow/DS_VideoDecoder.c and the other in
loader/dmo/DMO_VideoDecoder.c

> > -		    printf("%.4s ", &c->fcc);
> > +		    printf("%.4s ", (char*)&c->fcc);
> > 
> > Better?
> yes

Good.

> > > > -	*lpFilePart = strrchr(lpFileName, '\\');
> > > > +	lpFilePart = strrchr(lpFileName, '\\');
> > > >      else
> > > > -	*lpFilePart = lpFileName;
> > > > +	lpFilePart = lpFileName;
> > > 
> > > looks bad
> > 
> > But it's not bad. lpFilePart is LPTSTR and that is char *.
> imho it's char** (Long Pointer To STRing)

YHO is wrong. :-))
loader/wine/windef.h:
[...]
typedef char            CHAR;
[...]
typedef CHAR           *LPSTR;

[...]
> > > > -//#include <string.h>      // FIXME: conflicts with fs.h
> > > > +#include <string.h>      // FIXME: conflicts with fs.h
> > >                                       ^^^^^^^^^^^^^^^^^^^
> > 
> > Oh, this one is interesting. I couldn't find any fs.h file on my system
> > and in mplayer sources. WTF is it?
> 
> neither me, but some broken glibc versions / distribs had this problem.
> a warning is still better than a non-compiling mplayer.

Agreed. But you don't mind my including this in the RPMs?
They're compiled on my system and my glibc isn't broken.

[...] 
> i'll merge some of them.

OK.
 
-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"