[MPlayer-dev-eng] [PATCH] Yet another batch of warning fixes :->

Dominik Mierzejewski dominik at rangers.eu.org
Wed Dec 11 02:26:02 CET 2002


On Wednesday, 11 December 2002, Anders Johansson wrote:
[...] 
> I am sorry but your code:
> 
> > > > > > > +  xi=(xi-1)&(L-1);\
> > > > > > > +  xi--;
> 
> does not do the same thing as:
> 
> > > > +  xi=(xi-1)&(L-1);
> 
> You have to observe that this is a macro, not a function, your code
> would result in irregular indexing of the circular buffer.

I've already spotted it in the meantime, but indeed, you're right. 100l to
me for that. :-/

-- 
MPlayer RPMs maintainer: http://www.piorunek.pl/~dominik/linux/pkgs/mplayer/
"The Universe doesn't give you any points for doing things that are easy."
        -- Sheridan to Garibaldi in Babylon 5:"The Geometry of Shadows"



More information about the MPlayer-dev-eng mailing list