[MPlayer-dev-eng] [PATCH] video filter: aspect correction

[Arpi]

Hi,

> i attached another patch i made while trying to implement this in vf_scale.c
> (scale.diff). this reduces the code for the parameter calculation a bit. i
> don't know if you call this cosmetics, if so, just ignore it :)

its' not only codmetics, but it changes the effect of that code.
ie it does teh &~1 masking ONLY if it calculated the sizes. it allowed users
to give odd resolutions. your version doesn't...
i was close to aplpy it, but htere was a discussion about this part of the
code long time ago i remembered.

> 	d_height = d_width * vf->priv->aspect * d_height / d_width;

in short: d_height*=vf->priv->aspect;

why to overcomplicate by *d_width and /d_width ?
it's very misleading and useless.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu