[MPlayer-dev-eng] new cfgparser - broken by design? :(

[Arpi]

Hi,

Ok i've located and fixed the 'sig11 when quit playing vcd/dvd' bug,
but it turned out to be a configparser design bug.

Actually it assumes that ONLY the cfgparser may write the variables.
It is NOT true for too many cases in mplayer, due to the old parser
code had different behaviour.
Yes, one (and proabbly the nicer) way is going through the whole source
and fix all those direct writes to these variables, but
1. it's too much work
2. it won't help, new patches will re-introduce the problem
also it's a never-ending instability issue... (you know how hard to trace
down mem. corruptions caused by some bad free() calls?)

So, Albeu, please change (ASAP...) the new cfg parser to allow external
writes to the cfg variables (just like the old config code), and
don't try to free() their values unless it was allocated by the cfg parser.

This dvd_device="/dev/dvd"; was a good example (cfgparser tried to
free(dvd_device) at exit causing random sig11), but there are lots of such
code out there...


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu