[MPlayer-dev-eng] [PATCH] mga_vid memleak fix

[Attila Kinali]

On Sun, 3 Feb 2002 13:50:24 -0500
D Richard Felker III <dalias at aerifal.cx> wrote:

> well see, that's not enough -- mplayer's text output gets trashed
> while it's playing even, as does any other text that gets printed,
> e.g. if you switch to another console to irc or something while the
> movie is playing.

Hmm.. never had such effects. What is your kernel config and
which resolution do you have on the console ?
Mine:
2.2.19
G200 8MB
CONFIG_FB=y
CONFIG_FB_MATROX=y
CONFIG_FB_MATROX_G100=y
CONFIG_FBCON_ADVANCED=y
CONFIG_FBCON_CFB8=y
CONFIG_FBCON_CFB16=y
CONFIG_FBCON_CFB24=y
CONFIG_FBCON_CFB32=y
CONFIG_FBCON_FONTS=y
CONFIG_FONT_8x8=y
CONFIG_FONT_8x16=y
(the rest is unset)
res is 800x600 at 8bpp

> fyi, i only have 8 megs, and it's more than enough for mga_vid even
> with the font-preserving hack i put in. but, it probably would make
> the most sense to make the amount of memory skipped for font space a
> module loadtime option, so that users can just configure it in
> modules.conf. sound good?

Juup, that sound far better.
Also the "save memory" could be done as an option

		Attila Kinali
-- 
I am a moslem, i am a terrorist.