[MPlayer-dev-eng] [PATCH] autodetect screen size for vo_mga fullscreen

[Jason Lunz]

kinali at gmx.net said:
> Changing default is always considered a bad thing if it doesnt improve
> the situation for more than half of the people.

The patch doesn't change anything if you don't use -vo mga. 95% of those
who do use vo_mga will get automatic screen size detection, so they'll
have a centered picture and a working -fs. The other 5% who are using
/dev/fb1 may have incorrect defaults, but _the existing default is wrong
anyway_, so they're already using -screenh and -screenw. The patch makes
them no worse off than before.

> I dont think this automatic /dev/fb0 will make it into mplayer because
> it could be problematic.

It's not problematic. The code falls back to the old behavior if there's
any problem getting the size from /dev/fb0. This is only used _at_all_
if you're using -vo mga, and vo_mga only works if you're using the
framebuffer. (I compiled a kernel last night without framebuffer and
tried vo_mga. It didn't work.)

> Dunno, that's Arpi's decision. Try to implement something that makes
> sense to you and send a patch. If the developer like it, they'll
> commit it.

I'll look at it, but I honestly don't know why you'd need another
framebuffer device. Is it for the second head on dual-head setups?

> IIRC Arpi said once something like it's not easily possible.

what? if you know the fbdev, getting the screen size is just
ioctl(fbfd, FBIOGET_VSCREENINFO).

Jason