[MPlayer-dev-eng] TODO

[Arpi]

Hi,

> > > > URGENT:
> > > > - implement software scaling to vo_mpegpes
> > > >   *** Hmm. It's mine :)
> > > 
> > > As you didn't like me adding -scalefactor to use swscaling in the dxr3
> > no. i have problem with 'how'. you added dxr3 speicifc variable to
> > mplayer.c, instead of vo_dxr3.c where it belongs to.
> 
> Ah, I thought you didn't like that I added a new switch, and I was under
> the impression that all new variables had to be added to mplayer.c,
> mistake corrected, new patch attached.

only player switches should be at mplayer.c
libvo switches at video_out.c, if it's specific to a single vo_XX then it
should be at vo_XX.c...

> 
> Index: cfg-mplayer.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/cfg-mplayer.h,v
> retrieving revision 1.132
> diff -u -r1.132 cfg-mplayer.h
> --- cfg-mplayer.h	12 Feb 2002 15:05:58 -0000	1.132
> +++ cfg-mplayer.h	12 Feb 2002 17:16:24 -0000
> @@ -76,6 +76,10 @@
>  extern void vo_aa_revertoption(config_t* opt,char* param);
>  #endif
>  
> +#ifdef HAVE_DXR3
> +float scalefactor=1.0;
> +#endif

ehh... shouldn't make declaration at cfg-*.
it should be 'extern' here, don't you think???


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu