[MPlayer-dev-eng] Re: [PATCH] Clean up demuxers

[Alban Bedel]

Hi Daniel Egger,

on 24 Feb 2002 18:23:57 +0100 you wrote:

> Hija,
> 
> > There is now 2 special demuxer number :)
> 
> Wouldn't be a problem, the idea is scalable. :)
> 
> > And this look like a very bad solution.
> 
> Not as far as I can see.
>
> > Anyway using an array like you have done isn't the right way.
> 
> Convince me otherwise. :)
> 
> > You should put the functions inside the demuxer_t struct itself.
> > Then during opening, the demuxer itself fill this fields with the
> > correct function. It's the same thing but it doesn't need any array
> > or things like that. Even cleaner :)
> 
> Sound like you thought about it; unfortunately I've no idea what exactly
> you would change so please elaborate or change it and I'll see. :)
I'm not fighting about who is right. But you sound too sure of you for me.
If you want to see something happen, do it but you must accept critcs
from other ppl who alredy work on the project.
	Albeu