[MPlayer-dev-eng] Re: Another warning and functionality fix

Arpi arpi at thot.banki.hu
Tue Feb 26 01:19:25 CET 2002


Hi,

> >> -      video_out->draw_frame(&pkg);
> >> +      video_out->draw_frame(&(pkg->data));
> 
> > this is wrong
> 
> I assumed so but since
> 
> static vo_mpegpes_t *pkg=&packet;
> 
> and vo_mpegpes_t is a compound structure while draw_frame
> is prototyped as
> 
> uint32_t draw_frame(uint8_t *src[]);
> 
> I'm pretty confident that the former version is fishy.

i've added package struct and have to pass it to draw_frame without changing
the whole libvo api, so as a quick hack, it's typecasted to char* and
back... i agree in that it's ugly but it's my problem, and as your "fix"
won't work it's wrong. ok?


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-dev-eng mailing list