[MPlayer-dev-eng] Re: [PATCH] Development (Was: Clean up demuxers)

[Arpi]

Hi,

> > >       s = (char*)malloc((strlen(param) + 6 + 1)*sizeof(char));

> > what's the problem with this? it is not my code, anyway it looks ok for me
> .
> 
> The multiplication with sizeof(char) is redundant. Since sizeof(char)
> is the base unit for sizeof(), it must always be 1 ;) (OK, actually, I
> also can't see the problem...)

hmm. i've worked with watcom c compiler under dos/win some time ago, and it
has an option to set char to 16bit, to handle wide/unicode stuff
automagically. it sets the size of char type to 2 bytes.


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu