[MPlayer-dev-eng] PATCH: XviD/OpenDivX vs mplayer namespace clash

[Arpi]

Hi,

>     This is not really an mplayer issue, but I noticed it in that
> context. The OpenDivX/XviD/whatever decore library (and I think the
> last source you could get from Mayo before they decided to pretend
> that they're trying to fix their CVS server :/ ) has some namespace
> issues; this patch changes a couple of variable names:
> 
>   idct        -> idct_func
>   postprocess -> postprocess_func
> 
> to allow it to work with mplayer. As usual with my work, it's just
> the bare minimum to get the job done.
> 
>    Otherwise, I seem to be able to encode and play movies with
> mplayer using this library. I haven't looked at the mplayer configure
> setup yet, but if it's not already done, I'll probably hack in something
> to let it build and use a local static version of this lib if it's
> placed in the source tree, as with ffmpeg.
> 
>    Anyone interested? Anyone know a reason it shouldn't be done?
yes, we're interested.

but i don't really understand the sense of this patch.
opendivx decode is NOT compiled and linked if external divx4/odivx/xvid liek
library is used. and even if it would be linked, it won't eb used as both
libs use encore() and decore() functions so they always clash...

so i see no sense of patching decore/* to get xvid working, as you cannot
use both library in hte same mplayer binary.
currently, if divx4linux is detected/selected then opendivx won't be
compiled. we should just replace divx4linxu by xvid when it gets stable.
(last time we tried it just did sig11)


A'rpi / Astral & ESP-team

--
mailto:arpi at thot.banki.hu
http://esp-team.scene.hu