[MPlayer-dev-eng] patch--- provides joystick support in mplayer

[Rick]

The definitions in input.h are completely different from the ones in 
keycodes.h.  Mplayer should not define things that are already defined in 
another fairly standard include file.  That is why I changed the definitions 
to MP_KEY_WHATEVER.  Changing the conflicting header would mean changing the 
standard linux kernel source include file....
One should not need to modify their kernel source to be able to compile 
joystick support into mplayer.

I did a grep -r for all files using those definitions and made all the 
necessary changes from KEY_UP to MP_KEY_UP, etc, etc.

Redefining an already defined symbol is a bug.  I fixed it.

On Monday 14 January 2002 07:29 pm, you wrote:
> Hi,
>
> > This patch add's joystick support if HAVE_JOYSTICK is defined at compile
> > time. I have set it up to support 2 axes and 4 buttons.. more buttons are
> > just ignored.  the joystick controls are are follows (i'm just listing
> > the equivalent keyboard command)
> > left-left
> > right-right
> > up-up
> > down-down
> > button 1- lower volume
> > button 2- raise volume
> > button 3 -pause
> > button 4 - quit
> >
> > SOMEONE NEEDS TO ADD JOYSTICK STUFF INTO THE CONFIGURE SCRIPT
> > I  do not know how to add the stuff to the configure script.. so please
> > add it for me.  Joystick support needs to have HAVE_JOYSTICK defined.
>
> it's ok. but i really don't like your changes to key code names over the
> whole source tree. is it really needed? any workaround?
>
> at worst case, in your file including the conflicting header:
>
> #define MP_KEP_UP KEY_UP
> #undef KEY_UP
>
> #include <conflicting/include.h>
>
> ...
>
>
> A'rpi / Astral & ESP-team