[MPlayer-dev-eng] Re: [PATCH] xv-options (brightness etc)

[Pásztor Szilárd]

Nick:
> I've applied this patch after serious modifcation it.
> If it will cause problems - please comment out set_gamma_correction() call
> in init() function of vo_xv.c

Hm :) it doesn't seem to work.
The function calls are missing in mplayer.c. How is it intended to be used?
Now the user can't control the settings with keys 1-8.

My other issue with it: the SET_XV_DEFAULTS setting is very necessary imo.
This trigger made sure that upon mplayer start, the xv things are reset.
Otherwise the control gets out of hand (because values inside mplayer are
all reset to 50) and after a 2nd start, it is easy to crash the player with
BadValue errors. Init used this setting-to-default and it needed
SET_XV_DEFAULTS to be the first in the structure.

3rd issue: The structure was meant to be expandable. That is, if any new
attribute is needed, it is (was :)) enough to make a new entry in the struct
for it.

s.

            -------------------------------------------------------
            |  It's all fun and games till someone loses an eye;  |
            |         Then it's fun, just you can't see.          |
            -------------------------------------------------------